Messages in this thread | | | Date | Wed, 30 Aug 2006 11:59:40 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit (ping) |
| |
Alon Bar-Lev wrote: > > This is not entirely true... > All architectures sets saved_command_line variable... > So I can add __init to the saved_command_line and > copy its contents into kmalloced persistence_command_line at > main.c. >
My opinion is that you should change saved_command_line (which already implies a copy) to be the kmalloc'd version and call the fixed-sized buffer something else.
-hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |