Messages in this thread | | | Subject | Re: [PATCH] aic94xx: Increase can_queue and cmds_per_lun | From | James Bottomley <> | Date | Wed, 30 Aug 2006 13:19:43 -0400 |
| |
On Mon, 2006-08-28 at 22:23 -0700, Darrick J. Wong wrote: > - .cmd_per_lun = 1, > + .cmd_per_lun = 2,
This is an old piece of code. Today we use 1 for the cmd_per_lun of non-TCQ devices.
> + aic94xx_sht.can_queue = asd_ha->hw_prof.max_scbs - ASD_FREE_SCBS;
This is unnecessary unless you alter it before host alloc (which is where it takes the shost values from the template).
Also, I think if you look at the rest of the driver, it's careful to account for the need for required scbs in its internal queueing algorithms, so the ASD_FREE_SCBS should be unnecessary.
> + shost->can_queue = aic94xx_sht.can_queue;
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |