Messages in this thread | | | Date | Wed, 30 Aug 2006 09:30:00 -0700 | From | Zach Brown <> | Subject | Re: [2.6.18-rc5 PATCH]: aio cleanup |
| |
Yi Yang wrote: > As Zach Brown said, a cleanup patch is reasonable. Here it is.
I said a cleanup patch could be reasonable :)
> This patch extracts the common part from aio_fsync and aio_fdsync > and define a new inlined function aio_xsync, then aio_fsync and > aio_fdsync just call aio_xsunc in the almost same way except second > argument is different, one is 1 and another 0.
I don't think we need to change this, to be honest. They're tiny functions without users. It doesn't seem worth the trouble, minimal though it is.
Maybe if we had ->aio_fsync() users it would be more clear if there was an opportunity to really clarify the interface.
- z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |