[lkml]   [2006]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 001/001] I2C: AD7414 I2C chip driver for Linux-
    On Fri, 04 Aug 2006 11:53:04 +1200 Theuns Verwoerd wrote:

    > AD7414 Temperature Sensor I2C driver. I2C chip driver for the Analog
    > Devices AD7414 device, exposes raw and decoded registers via sysfs.
    > Signed-off-by: Theuns Verwoerd <>
    > ---
    > Tested on a custom EP9315-based board developed in-house. Fairly trivial
    > driver; really just exposes the raw registers and temperature reading
    > to userspace.
    > Patch is relative to stock Linux-

    Patches should be made against latest mainline kernel, e.g.,
    2.6.18-rc3 (unless they are specifically for an -mm patch),
    although it probably doesn't matter in this case.

    > [This is my first go at a kernel submission, so feel free to point out
    > anything
    > that should be done differently]
    > ---
    > diff -uprN -X linux-
    > linux-
    > linux-
    > --- linux- 1970-01-01
    > 12:00:00.000000000 +1200
    > +++ linux- 2006-08-04
    > 10:28:37.000000000 +1200

    1/ Thunderbird is breaking (splitting) your lines for you. :(
    See if
    helps any. Try sending a patch to yourself and test if you
    can apply it. Or use a different mail client/app.
    Those 7 lines above should be 3 lines.
    You may need to unset some "flowed" attribute in tbird
    (I'm not sure of its full, correct name.)

    2/ Either thunderbird is converting tabs to spaces or the
    driver source does not contain tabs -- just lots of spaces.
    Please indent struct fields with one tab, embedded struct fields
    with 2 tabs, etc.

    3/ Macro continuation lines should be indented.

    4/ sysfs files should contain only one value per file. Use
    multiple files for multiple values.

    5/ Code labels should not be indented or maybe indented one space,
    and certainly not indented more than the following source lines.

    6/ device_create_file() and friends can return errors. They need
    to be checked for success/fail.

    7/ Header files should be included in linux/ alpha order, then
    asm/ alpha order, then local.h files unless there are reasons
    that this order won't work.
    (Yes, only linux/ applies here.)

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-08-04 05:23    [W:0.022 / U:2.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site