Messages in this thread | | | From | Rolf Eike Beer <> | Subject | Re: [PATCH] Move valid_dma_direction() from x86_64 to generic code | Date | Thu, 3 Aug 2006 08:25:19 +0200 |
| |
Muli Ben-Yehuda wrote: > On Wed, Aug 02, 2006 at 05:20:40PM +0200, Rolf Eike Beer wrote: > > As suggested by Muli Ben-Yehuda this function is moved to generic code as > > may be useful for all archs. > > I like it, but ...
> Several files include asm/dma-mapping.h directly, which will now cause > them to fail to compile on x86-64 due to the missing definition for > valid_dma_direction, unless by chance another header already brought > it in indirectly. I guess the right thing to do is convert them all to > using linux/dma-mapping.h instead.
Yes, akpm already fixed it up. Sorry guys, currently no x86 kernel around here. Need to fix that.
> ./arch/x86_64/kernel/pci-swiotlb.c:6:#include <asm/dma-mapping.h> > ./drivers/net/fec_8xx/fec_main.c:40:#include <asm/dma-mapping.h> > ./drivers/net/fs_enet/fs_enet.h:11:#include <asm/dma-mapping.h> > ./include/asm-x86_64/swiotlb.h:5:#include <asm/dma-mapping.h>
I suspect it to be a bug anyway that every of this files ever included asm/dma-mapping.h.
> ./include/linux/dma-mapping.h:27:#include <asm/dma-mapping.h>
This is perfectly valid, isn't it :)
Eike [unhandled content-type:application/pgp-signature] | |