Messages in this thread | | | Date | Thu, 3 Aug 2006 11:55:44 -0700 | Subject | Re: orinoco driver causes *lots* of lockdep spew | From | Jean Tourrilhes <> |
| |
On Thu, Aug 03, 2006 at 11:54:41PM +1000, Herbert Xu wrote: > Arjan van de Ven <arjan@infradead.org> wrote: > > > > this is another one of those nasty buggers; > > Good catch. It's really time that we fix this properly rather than > adding more kludges to the core code. > > Dave, once this goes in you can revert the previous netlink workaround > that added the _bh suffix. > > [WIRELESS]: Send wireless netlink events with a clean slate > > Drivers expect to be able to call wireless_send_event in arbitrary > contexts. On the other hand, netlink really doesn't like being > invoked in an IRQ context. So we need to postpone the sending of > netlink skb's to a tasklet.
Yes, this was needed. I really like the way you implemented it, simple and efficient. Go for it !
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
For what it's worth : Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
> Cheers,
Thanks !
Jean - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |