Messages in this thread | | | Subject | Re: [ckrm-tech] [PATCH 6/7] BC: kernel memory (core) | From | Dave Hansen <> | Date | Tue, 29 Aug 2006 13:29:42 -0700 |
| |
On Tue, 2006-08-29 at 18:58 +0400, Kirill Korotaev wrote: > @@ -274,8 +274,14 @@ struct page { > unsigned int gfp_mask; > unsigned long trace[8]; > #endif > +#ifdef CONFIG_BEANCOUNTERS > + union { > + struct beancounter *page_bc; > + } bc; > +#endif > };
I know you're probably saving this union for when you put some userspace stuff in here or something. But, for now, it would probably be best just to leave it as a plain struct, or even an anonymous union.
You probably had to use gcc 2 when this was written and couldn't use anonymous unions, right?
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |