lkml.org 
[lkml]   [2006]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] [PATCH] file posix capabilities
    Quoting Seth Arnold (seth.arnold@suse.de):
    > On Mon, Aug 28, 2006 at 04:39:12PM -0500, Serge E. Hallyn wrote:
    > > +int cap_task_kill(struct task_struct *p, struct siginfo *info,
    > > + int sig, u32 secid)
    > > +{
    > > + if (info != SEND_SIG_NOINFO && (is_si_special(info) || SI_FROMKERNEL(info)))
    > > + return 0;
    > > +
    > > + if (secid)
    > > + /*
    > > + * Signal sent as a particular user.
    > > + * Capabilities are ignored. May be wrong, but it's the
    > > + * only thing we can do at the moment.
    > > + * Used only by usb drivers?
    > > + */
    > > + return 0;
    > > + if (current->uid == 0 || current->euid == 0)
    > > + return 0;
    >
    > uid/euid checks feel out of place in the capabilities code.

    Wow, good point.

    Will fix.

    thanks,
    -serge
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-29 22:01    [W:0.034 / U:30.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site