Messages in this thread | | | Date | Sun, 27 Aug 2006 10:09:42 -0700 | From | "Randy.Dunlap" <> | Subject | Re: HPA Resume patch |
| |
On Sun, 27 Aug 2006 04:42:03 -0400 Lee Trager wrote:
> This patch fixes a problem with computers that have HPA on their hard > drive and not being able to come out of resume from RAM or disk. I've > tested this patch on 2.6.17.x and 2.6.18-rc4 and it works great on both > of these. This patch also fixes the bug #6840. This is my first patch to > the kernel and I was told to e-mail the above people to get my patch > into the kernel. If I made a mistake please be gentle and correct me ;)
Please use inline patches if your mail system supports/allows it. Attachments make it difficult to review a patch. (now do some cp-n-paste for comments)
+/* Bits 10 of command_set_1 and cfs_enable_1 must be equal, + * so on non-buggy drives we need test only one. + * However, we should also check whether these fields are valid. +*/
Long comment style in Linux is: /* * foo bar * comments */
+static inline int idedisk_supports_hpa(const struct hd_driveid *id) +{ + return (id->command_set_1 & 0x0400) && (id->cfs_enable_1 & 0x0400); +}
Please use a #defined value for the 0x400. (Yes, you just moved it from somewhere else.)
+ /* check to see if this is a hard drive + * if it is then checkhpa needs to be + * disabled */
Comment style again.
+ if(drive->media == ide_disk && idedisk_supports_hpa(drive->id))
space after "if".
+ init_idedisk_capacity(drive);
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |