[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Strange transmit corruption in jsm driver on geode sc1200 system
    On Sat, Aug 26, 2006 at 01:24:41AM +0400, Alexey Dobriyan wrote:
    > But you can check. Insert something like this in right place:
    > printk("%p\n", buffer);

    It would be 1/4 of the time given the code is this:

    memcpy_toio(&ch->ch_neo_uart->txrxburst, ch->ch_wqueue + tail, s);

    tail is the offset in the write queue in the jsm driver, which can be
    any offset whatsoever. So sometimes it is 32bit aligned, but often it

    The txrxburst of course is 32bit alligned. Receiving works fine when
    copying from the alligned buffer in hardware to wherever in the receiver

    Of course given the __memcpy assembly seems to work fine unalligned on a
    pentium4, and probably most othe systems, what could make it not work
    correctly on a geode SC1200?

    This is the chunk of assembly in use:

    static __always_inline void * __memcpy(void * to, const void * from, size_t n)
    int d0, d1, d2;
    __asm__ __volatile__(
    "rep ; movsl\n\t"
    "movl %4,%%ecx\n\t"
    "andl $3,%%ecx\n\t"
    #if 1 /* want to pay 2 byte penalty for a chance to skip microcoded rep? */
    "jz 1f\n\t"
    "rep ; movsb\n\t"
    : "=&c" (d0), "=&D" (d1), "=&S" (d2)
    : "0" (n/4), "g" (n), "1" ((long) to), "2" ((long) from)
    : "memory");
    return (to);

    I am affraid I don't know the rep instruction on x86, so it really
    doesn't make sense to me.

    I suppose if nothing else works, I can do one byte at a time until the
    tail is 32bit alligned, and then do the rest of the transfer as a block
    and see if that makes it work, or whether it is broken no matter what
    the allignement of the buffer is.

    Len Sorensen
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-08-25 23:59    [W:0.028 / U:83.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site