lkml.org 
[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 22 of 23] IB/ipath - print warning if LID not acquired within one minute
    From
    Date
    1) What makes ipath special so that we want this warning for ipath
    devices but not other IB hardware? If this warning is actually
    useful, then I think it would make more sense to start a timer when
    any IB device is added, and warn if ports with a physical link don't
    become active after the timeout time. But I'm having a hard time
    seeing why we want this message in the kernel log.

    2) You do cancel_delayed_work() but not flush_scheduled_work(), so
    it's possible for your timeout function to be running after the module
    text is gone.

    - R.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-25 21:37    [W:4.432 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site