lkml.org 
[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: another NUMA build error
On Sat, 26 Aug 2006 03:28:34 +0900 KAMEZAWA Hiroyuki wrote:

> On Fri, 25 Aug 2006 10:35:07 -0700
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
> > OK, I prefer option 2 because it is more generic (not hardware-
> > specific). Someone else can prefer option 1 because it is
> > hardware-specific. :)
> >
> ok. patch is here. but people who know x86-numa should confirm this.
>
> -Kame
> --
> compile fix for
>
> In file included from include/asm/mmzone.h:18,
> from include/linux/mmzone.h:439,
> <snip>
> include/asm/srat.h:31:2: error: #error CONFIG_ACPI_SRAT not defined, and srat.h header has been included
> make[1]: *** [arch/i386/kernel/asm-offsets.s] Error 1
>
> This can happen with CONFIG_NUMA && !CONFIG_ACPI && !CONFIG_X86_NUMAQ
>
> Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>
> include/asm-i386/mmzone.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.18-rc4/include/asm-i386/mmzone.h
> ===================================================================
> --- linux-2.6.18-rc4.orig/include/asm-i386/mmzone.h
> +++ linux-2.6.18-rc4/include/asm-i386/mmzone.h
> @@ -14,7 +14,7 @@ extern struct pglist_data *node_data[];
>
> #ifdef CONFIG_X86_NUMAQ
> #include <asm/numaq.h>
> -#else /* summit or generic arch */
> +#elif defined(CONFIG_ACPI_SRAT)/* summit or generic arch */
> #include <asm/srat.h>
> #endif


That fixes mmzone.h but it still doesn't produce kernel that
will build without error:

arch/i386/mm/discontig.c: In function ‘zone_sizes_init’:
arch/i386/mm/discontig.c:388: warning: implicit declaration of function ‘get_zholes_size’
arch/i386/mm/discontig.c:388: warning: assignment makes pointer from integer without a cast

and:
LD .tmp_vmlinux1
arch/i386/mm/built-in.o: In function `zone_sizes_init':
(.init.text+0xd05): undefined reference to `get_zholes_size'
make: *** [.tmp_vmlinux1] Error 1

Same .config as in previous email.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-08-25 21:07    [from the cache]
©2003-2011 Jasper Spaans