Messages in this thread | | | Date | Fri, 25 Aug 2006 10:14:46 -0700 (LDT) | Subject | Re: [PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns_scale. | From | Toyo <> |
| |
From: Andi Kleen <ak@suse.de> Subject: Re: [PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns_scale. Date: Fri, 25 Aug 2006 18:55:57 +0200
> On Friday 25 August 2006 18:45, Toyo Abe wrote: > > The x86_64-mm-monotonic-clock.patch in 2.6.18-rc4-mm2 made a change to > > the updating of monotonic_base. It now uses cycles_2_ns(). > > > > I suggest that a set_cyc2ns_scale() should be done prior to the setup_irq(). > > Because cycles_2_ns() can be called from the timer ISR right after the irq0 > > is enabled. > > Added thanks. I folded it into the original patch. > > Did you actually see a failure or was this just from code review? > -Andi > I didn't see any failure on it. It was just a speculation. But I think it's better thing here.
Best Regards, toyo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |