lkml.org 
[lkml]   [2006]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] maximum latency tracking infrastructure (version 2)

    * Alexey Dobriyan <adobriyan@gmail.com> wrote:

    > > +#ifndef _INCLUDE_GUARD_LATENCY_H_
    > > +#define _INCLUDE_GUARD_LATENCY_H_
    > > +
    > > +#include <linux/notifier.h>
    >
    > Just
    > struct notifier_block;

    not really. Either use the #include, or if you want less stuff included,
    split notifier.h into notifier_types.h and notifier.h and move the data
    structure declarations to notifier_types.h and then #include
    notifier_types.h. (spinlock_types.h works like this.) This allows
    headers to be separated into pure 'data structure' and 'access methods'
    portions. Using explicit forward declarations is less cleaner.

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-25 16:09    [W:0.032 / U:119.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site