lkml.org 
[lkml]   [2006]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] BLOCK: Make it possible to disable the block layer
Date
David Woodhouse <dwmw2@infradead.org> wrote:

> > (*) The contents of a number of filesystem- and blockdev-specific header
> > files are now contingent on their own configuration options. This
> > includes: Ext3/JBD, RAID, MSDOS and ReiserFS.
>
> Why? Those header files shouldn't be included from anywhere _but_ the
> code in question,

Go and look at fs/compat_ioctl.c.

> and in fact should probably be just moved into fs/foo instead of living in
> include/linux/foo_fs.h.

Definitely. Patches please:-)

> And please, _never_ make anything dependent on CONFIG_foo_MODULE.

Ah, but... The core kernel makes use of the certain header files, even when
their actual intended target is compiled as a module. If I just use
"CONFIG_foo" only, then the module won't compile as a module.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-24 15:37    [W:0.134 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site