lkml.org 
[lkml]   [2006]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix x86_64 _spin_lock_irqsave()
    Andi Kleen wrote:
    > Edward Falk <efalk@google.com> writes:
    >
    >
    >>Add spin_lock_string_flags and _raw_spin_lock_flags() to
    >>asm-x86_64/spinlock.h so that _spin_lock_irqsave() has the same
    >>semantics on x86_64 as it does on i386 and does *not* have interrupts
    >>disabled while it is waiting for the lock.
    >
    >
    > Did it fix anything for you?

    I think this was to work around the fact that some buggy drivers try to
    grab spinlocks without disabling interrupts when they should, which
    would cause deadlocks when trying to rendez-vous every cpu via IPIs.

    It's a bad idea to spin with interrupts disabled when they could very
    well be enabled, anyway.

    -- Suleiman
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-24 13:07    [W:0.031 / U:93.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site