Messages in this thread | | | Date | Wed, 23 Aug 2006 17:53:11 +0400 | From | Alexey Dobriyan <> | Subject | Re: [PATCH 2/6] BC: beancounters core (API) |
| |
> >>+void __put_beancounter(struct beancounter *bc) > >>+{ > >>+ unsigned long flags; > >>+ > >>+ /* equivalent to atomic_dec_and_lock_irqsave() */ > >>+ local_irq_save(flags); > >>+ if (likely(!atomic_dec_and_lock(&bc->bc_refcount, &bc_hash_lock))) { > >>+ local_irq_restore(flags); > >>+ if (unlikely(atomic_read(&bc->bc_refcount) < 0)) > >>+ printk(KERN_ERR "BC: Bad refcount: bc=%p, " > >>+ "luid=%d, ref=%d\n", > >>+ bc, bc->bc_id, > >>+ atomic_read(&bc->bc_refcount)); > > > > > >Should this BUG_ON() ? > BUG_ON doesn't print much information :) > ok, will replace
but printk + BUG does ;-)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |