lkml.org 
[lkml]   [2006]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: sym53c8xx PCI card broken in 2.6.18
From
From: "Eric Brower" <ebrower@gmail.com>
Date: Tue, 22 Aug 2006 22:35:14 -0700

> Would you consider assigning -1 to lenp (if provided) in
> of_find_property() when no matching device is found?

I think checking for NULL should be the first thing a caller of these
interfaces should do. So from that perspective, I don't think putting
anything in *lenp makes sense. It's value is undefined.

In fact since we'll leave *lenp alone if the property doesn't exist,
you can initialize it to -1 if you want to simplify your checks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-23 07:53    [W:0.058 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site