Messages in this thread | | | Date | Tue, 22 Aug 2006 09:48:55 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [take12 3/3] kevent: Timer notifications. |
| |
On Mon, Aug 21, 2006 at 09:36:50PM -0700, Andrew Morton (akpm@osdl.org) wrote: > On Mon, 21 Aug 2006 16:09:34 +0400 > Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote: > > > On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig (hch@infradead.org) wrote: > > > > +static int __init kevent_init_timer(void) > > > > +{ > > > > + struct kevent_callbacks tc = { > > > > + .callback = &kevent_timer_callback, > > > > + .enqueue = &kevent_timer_enqueue, > > > > + .dequeue = &kevent_timer_dequeue}; > > > > > > I think this should be static, and the normal style to write it would be: > > > > > > static struct kevent_callbacks tc = { > > > .callback = kevent_timer_callback, > > > .enqueue = kevent_timer_enqueue, > > > .dequeue = kevent_timer_dequeue, > > > }; > > > > > > also please consider makring all the kevent_callbacks structs const > > > to avoid false cacheline sharing and accidental modification, similar > > > to what we did to various other operation vectors. > > > > Actually I do not think it should be static, since it is only used for > > initialization and it's members are copied into main structure. > > > > It should be static __initdata a) so we don't need to construct it at > runtime and b) so it gets dropped from memory after initcalls have run. > > (But given that kevent_init_timer() also gets dropped from memory after initcalls > it hardly matters).
That's what I'm talking about.
-- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |