Messages in this thread | | | Date | Mon, 21 Aug 2006 15:58:31 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try |
| |
On Mon, 21 Aug 2006 00:52:09 +0200 Lennart Poettering <mzxreary@0pointer.de> wrote:
> +static ssize_t store_auto_brightness( > + struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) { > + > + int enable, ret;
Please follow the usual kernel coding style, which would yield something like:
static ssize_t store_auto_brightness(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { int enable, ret;
(affects entire patch).
And please also prepare and maintain a standalone changelog. The one you have here is full of references to some long-gone email. Think: "how will my changelog look when it is in the main git tree".
Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |