lkml.org 
[lkml]   [2006]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Patch] Signedness issue in drivers/net/3c515.c
From
Date
Ar Llu, 2006-08-21 am 14:05 -0700, ysgrifennodd Andrew Morton:
> /* Wait for the stall to complete. */
> for (i = 20; i >= 0; i--)
> if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0)
> break;
>
> Your fix will convert this indefinit wait into a bounded one. It might
> cause the driver to malfunction.

The change is correct. The docs guarantee it can't take that long.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-21 23:55    [W:0.055 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site