lkml.org 
[lkml]   [2006]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Complaint about return code convention in queue_work() etc.
    From
    Date
    On Fri, 2006-08-18 at 17:39 -0400, Alan Stern wrote:
    > Why do the damn things return 0 for error and 1 for success???
    > Why don't they use negative error codes for failure, like
    > everything else in the kernel?!!
    >
    > I've tripped over this at least twice, and on each occasion spent a
    > considerable length of time trying to track down the problem.

    yeah, lets just flip the logic over, but combined with a rename so that
    we dont surprise not-yet-in-tree code [and documentation/books].
    queue_work() -> add_work() or something like that.

    Ingo

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-20 13:15    [W:0.022 / U:0.420 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site