Messages in this thread | | | Date | Sun, 20 Aug 2006 12:17:06 +0000 | From | Frederik Deweerdt <> | Subject | Re: [mm patch] drm, minor fixes |
| |
On Sun, Aug 20, 2006 at 11:37:06AM +0200, Arjan van de Ven wrote: > On Sat, 2006-08-19 at 23:16 +0000, Frederik Deweerdt wrote: > > On Sun, Aug 13, 2006 at 01:24:54AM -0700, Andrew Morton wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm1/ > > > > > Hi Andrew, > > > > The following patch adds minor fixes to the drm code: > > - fix return values that are wrong (return E* instead of return -E*) > > are you sure the callers of these don't wrap it inside a DRM_ERR() > macro ? I changed the values when: - I've checked what seemed right, getting back to the system call. drm_ioctl(), through a call to func(). That's the case for: - the EFAULT value in i915_emit_box - two EINVAL values in drm_setversion - the return value wasn't used. That was the case for drm_set_busid return values, I felt having returned values negative from the start was more consistent.
Is there a particular change that looked suspicious to you? Thanks, Frederik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |