lkml.org 
[lkml]   [2006]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here
* Zachary Amsden (zach@vmware.com) wrote:
> Andi Kleen wrote:
> >nst char *arch_vma_name(struct vm_area_struct *vma);
> >
> >>
> >>+#ifndef pgd_free_mm
> >>+#define pgd_free_mm(mm) pgd_free((mm)->pgd)
> >>+#endif
> >>
> >
> >Sorry, but these ifdefs are too ugly. I would prefer if you
> >just updated all architectures, even though it will make the patch
> >somewhat bigger
> >
> I'm fine with doing that, and yes this is ugly. Will take awhile though
> - for efficiency of mercurial patch tools, I deprecated all
> architectures but i386, x86_64, and um from my local tree. <Slaps head>.

While you're at it, can you please make sure there's some nice changelog
comments. The current one only has diffstat.

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-02 09:15    [W:0.813 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site