Messages in this thread | | | From | Rolf Eike Beer <> | Subject | Re: single bit flip detector. | Date | Wed, 2 Aug 2006 08:20:26 +0200 |
| |
Dave Jones wrote: > On Tue, Aug 01, 2006 at 07:51:09PM -0400, Dave Jones wrote: > > I'm going for the record of 'most times a patch gets submitted in one > > day'. And to think we were complaining that patches don't get enough > > review ? :) If every change had this much polish, we'd be awesome. > > Sigh. Spaces before printk. Whatever next. > I am now officially bored of seeing this patch.
> diff --git a/mm/slab.c b/mm/slab.c > index 21ba060..39f1183 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -1638,10 +1638,28 @@ static void poison_obj(struct kmem_cache > static void dump_line(char *data, int offset, int limit) > { > int i; > + unsigned char total = 0, bad_count = 0, errors; > printk(KERN_ERR "%03x:", offset); > - for (i = 0; i < limit; i++) > + for (i = 0; i < limit; i++) {
You might want to add a newline before the actual code to make it more readable :)
Eike [unhandled content-type:application/pgp-signature] | |