Messages in this thread Patch in this message | | | Date | Wed, 2 Aug 2006 19:50:31 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: mm snapshot broken-out-2006-08-02-00-27.tar.gz uploaded |
| |
On Wed, 2 Aug 2006, Michal Piotrowski wrote: > On 02/08/06, akpm@osdl.org <akpm@osdl.org> wrote: > > The mm snapshot broken-out-2006-08-02-00-27.tar.gz has been uploaded to > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2006-08-02-00-27.tar.gz > > > > It contains the following patches against 2.6.18-rc3: .... > > Here is something new, previous mm snapshot was fine > > Aug 2 19:56:08 ltg01-fedora kernel: ------------[ cut here ]------------ > Aug 2 19:56:08 ltg01-fedora kernel: kernel BUG at > /usr/src/linux-work4/mm/shmem.c:1228! > 1228 BUG_ON(!(vma->vm_flags & VM_CAN_INVALIDATE)); > > I will revert > fix-the-race-between-invalidate_inode_pages-and-do_no_page.patch > fix-the-race-between-invalidate_inode_pages-and-do_no_page-tidy.patch > and see what will happen.
Rather than reverting those, please add something like (I've not seen this particular tree) the fixup below - it's easily missed that ipc/shm.c has its own reference to shmem_nopage. (Last I heard, the flag was called VM_CAN_INVLD, but it looks like I'm not the only one averse to unpronounceables.)
Hugh
--- 2.6.18-rc2-mm1/ipc/shm.c 2006-07-27 16:19:18.000000000 +0100 +++ linux/ipc/shm.c 2006-08-02 19:29:46.000000000 +0100 @@ -264,6 +264,7 @@ static struct vm_operations_struct shm_v .set_policy = shmem_set_policy, .get_policy = shmem_get_policy, #endif + .vm_flags = VM_CAN_INVALIDATE, }; static int newseg (struct ipc_namespace *ns, key_t key, int shmflg, size_t size) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |