Messages in this thread | | | Date | Wed, 2 Aug 2006 07:18:45 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH v3] ifdef blktrace debugging fields |
| |
On Wed, Aug 02 2006, Alexey Dobriyan wrote: > On Tue, Aug 01, 2006 at 10:12:57PM +0200, Jens Axboe wrote: > > > +#ifdef CONFIG_BLK_DEV_IO_TRACE > > > if (q->blk_trace) > > > blk_trace_shutdown(q); > > > - > > > +#endif > > > kmem_cache_free(requestq_cachep, q); > > > } > > > > That can be made ifdef less, if you unconditionally call > > blk_trace_shutdown() and just make that one do: > > > > if (q->blk_trace) { > > ... > > } > > > > since that'll then do the right always. Please make that change, then > > I'm fine with the patch. > > OK here goes version 3. > > [PATCH] ifdef blktrace debugging fields
Looks good!
Acked-by: Jens Axboe <axboe@suse.de>
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |