lkml.org 
[lkml]   [2006]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] UART driver for PNX8550/8950 revised
On Sat, Aug 19, 2006 at 01:34:26PM +0400, Vitaly Wool wrote:
> Hello Russell,
> >serial_pnx8xxx.h just contains structure and register definitions for
> >this driver - wouldn't it make more sense for it to be in drivers/serial
> >along side this driver?
>
> Well it's used in arch/mips/philips/... so I doubt it's a right thing
> to move it to drivers/serial.

Okay, then it should stay where it is.

> >> + /*
> >> + * Disable all interrupts, port and break condition.
> >> + */
> >> + serial_out(sport, PNX8XXX_IEN, 0);
> >
> >This comment's not correct - where is the break condition disabled?
> >I thought it might be in the next serial_out() but it seems to be
> >missing from there as well?
>
> I don't think you're right here - break condition is also disabled
> unsetting the corresponding bit in IEN register for this particular
> UART.

Hmm, in that case why does break_ctl do this:

+ lcr = serial_in(sport, PNX8XXX_LCR);
+ if (break_state == -1)
+ lcr |= PNX8XXX_UART_LCR_TXBREAK;
+ else
+ lcr &= ~PNX8XXX_UART_LCR_TXBREAK;
+ serial_out(sport, PNX8XXX_LCR, lcr);

which appears to imply that the bit for the break state is in the LCR.
Moreover, there isn't a PNX8XXX_INT_* bit defined for break. Confused.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-19 11:57    [W:0.038 / U:32.760 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site