Messages in this thread | | | Subject | Re: [Ext2-devel] [PATCH] fix ext3 mounts at 16T | From | Mingming Cao <> | Date | Fri, 18 Aug 2006 11:53:20 -0700 |
| |
On Fri, 2006-08-18 at 12:39 -0500, Eric Sandeen wrote: > Mingming Cao wrote: > > > Yes, this isn't being addressed in the current 2.6.18-rc4 kernel. I > > think this is better than casting to unsigned long long: > > > > - if ((my_rsv->rsv_start >= group_first_block + EXT3_BLOCKS_PER_GROUP(sb)) > > + if ((my_rsv->rsv_start > group_first_block - 1 + EXT3_BLOCKS_PER_GROUP(sb)) > > And there are a few more of these. The patch I currently have in my stack follows. > (personally I think > last = first + (count - 1) > is clearer than > last = first - 1 + count > but that's just my opinion...) > > Thanks, >
ACK. > -Eric > > Signed-off-by: Eric Sandeen <esandeen@redhat.com> > > Index: linux-2.6.17/fs/ext3/balloc.c > =================================================================== > --- linux-2.6.17.orig/fs/ext3/balloc.c > +++ linux-2.6.17/fs/ext3/balloc.c > @@ -168,7 +168,7 @@ goal_in_my_reservation(struct ext3_reser > ext3_fsblk_t group_first_block, group_last_block; > > group_first_block = ext3_group_first_block_no(sb, group); > - group_last_block = group_first_block + EXT3_BLOCKS_PER_GROUP(sb) - 1; > + group_last_block = group_first_block + (EXT3_BLOCKS_PER_GROUP(sb) - 1); > > if ((rsv->_rsv_start > group_last_block) || > (rsv->_rsv_end < group_first_block)) > @@ -897,7 +897,7 @@ static int alloc_new_reservation(struct > spinlock_t *rsv_lock = &EXT3_SB(sb)->s_rsv_window_lock; > > group_first_block = ext3_group_first_block_no(sb, group); > - group_end_block = group_first_block + EXT3_BLOCKS_PER_GROUP(sb) - 1; > + group_end_block = group_first_block + (EXT3_BLOCKS_PER_GROUP(sb) - 1); > > if (grp_goal < 0) > start_block = group_first_block; > @@ -1132,7 +1132,7 @@ ext3_try_to_allocate_with_rsv(struct sup > try_to_extend_reservation(my_rsv, sb, > *count-my_rsv->rsv_end + grp_goal - 1); > > - if ((my_rsv->rsv_start >= group_first_block + EXT3_BLOCKS_PER_GROUP(sb)) > + if ((my_rsv->rsv_start > group_first_block + (EXT3_BLOCKS_PER_GROUP(sb) - 1)) > || (my_rsv->rsv_end < group_first_block)) > BUG(); > ret = ext3_try_to_allocate(sb, handle, group, bitmap_bh, grp_goal, > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Ext2-devel mailing list > Ext2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ext2-devel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |