lkml.org 
[lkml]   [2006]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 5/7] NFS: Use local caching [try #12]
Date
Chuck Lever <chucklever@gmail.com> wrote:

> > +static uint16_t nfs_server_get_key(const void *cookie_netfs_data,
> > + void *buffer, uint16_t bufmax)
> > +{
>
> Why don't you use the function declaration style that is used in the
> rest of the NFS client?

Actually, the NFS client has several different styles, and mine's not without
precedent, eg:

extern int nfs3_setxattr(struct dentry *, const char *,
const void *, size_t, int);

extern ssize_t nfs_direct_IO(int, struct kiocb *, const struct iovec *, loff_t,
unsigned long);

static inline loff_t
nfs_size_to_loff_t(__u64 size)

> All the parameters belong on one line, don't they?

Depends how much you want to upset those people who tremble with anxiety at
the sight of a line longer than 80 chars.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-18 17:53    [W:0.698 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site