lkml.org 
[lkml]   [2006]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [Ext2-devel] [PATCH 1/9] extents for ext4
    On Aug 15, 2006  15:40 +0000, Pavel Machek wrote:
    > > --- linux-2618-rc4-ext4.orig/include/linux/ext4_fs_extents.h
    > > +++ linux-2618-rc4-ext4/include/linux/ext4_fs_extents.h
    > > @@ -22,29 +22,29 @@
    > > #include <linux/ext4_fs.h>
    > >
    > > /*
    > > - * with AGRESSIVE_TEST defined capacity of index/leaf blocks
    > > - * become very little, so index split, in-depth growing and
    > > - * other hard changes happens much more often
    > > - * this is for debug purposes only
    > > + * With AGRESSIVE_TEST defined, the capacity of index/leaf blocks
    > > + * becomes very small, so index split, in-depth growing and
    > > + * other hard changes happen much more often.
    > > + * This is for debug purposes only.
    > > */
    > > #define AGRESSIVE_TEST_
    >
    > Using _ for disabling is unusual/nasty.

    I've always thought the same. I'd prefer just commenting out the whole
    line.

    > Can't we simply #undef it?

    Use of #undef is not so great, since that means it isn't possible to
    #define this flag in another header, on the make command-line, etc.

    Cheers, Andreas
    --
    Andreas Dilger
    Principal Software Engineer
    Cluster File Systems, Inc.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-18 15:11    [W:0.020 / U:31.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site