lkml.org 
[lkml]   [2006]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv2 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code
From
Hi,

In article <Pine.LNX.4.64.0608171054560.19149@d.namei> (at Thu, 17 Aug 2006 10:56:40 -0400 (EDT)), James Morris <jmorris@namei.org> says:

> On Thu, 17 Aug 2006, gerrit@erg.abdn.ac.uk wrote:
>
> > - if (inet2->num == snum &&
> > - sk2 != sk &&
> > - !ipv6_only_sock(sk2) &&
> > - (!sk2->sk_bound_dev_if ||
> > - !sk->sk_bound_dev_if ||
> > - sk2->sk_bound_dev_if == sk->sk_bound_dev_if) &&
>
>
> > + sk_for_each(sk2, node, head)
> > + if (inet_sk(sk2)->num == snum &&
> > + sk2 != sk &&
> > + (!sk2->sk_reuse || !sk->sk_reuse) &&
> > + (!sk2->sk_bound_dev_if || !sk->sk_bound_dev_if
> > + || sk2->sk_bound_dev_if == sk->sk_bound_dev_if) &&
>
>
> Doesn't this change the behavior for IPV6_V6ONLY sockets ?

It is tested in ipv4_rcv_saddr_equal() (called vi saddr_cmp), isn't it?

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-17 17:19    [W:0.050 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site