Messages in this thread | | | Date | Thu, 17 Aug 2006 05:14:49 -0700 | From | Greg KH <> | Subject | Re: [RFC][PATCH 2/7] UBC: core (structures, API) |
| |
On Thu, Aug 17, 2006 at 03:45:56PM +0400, Kirill Korotaev wrote: > >>+struct user_beancounter > >>+{ > >>+ atomic_t ub_refcount; > > > > > >Why not use a struct kref here instead of rolling your own reference > >counting logic? > > We need more complex decrement/locking scheme than krefs > provide. e.g. in __put_beancounter() we need > atomic_dec_and_lock_irqsave() semantics for performance optimizations.
Ah, ok, missed that. Nevermind then :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |