Messages in this thread | | | Date | Tue, 15 Aug 2006 18:46:06 +0400 | From | Oleg Nesterov <> | Subject | Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex |
| |
On 08/15, Esben Nielsen wrote: > > On Tue, 15 Aug 2006, Oleg Nesterov wrote: > > > >Sure, this needs a comment. > > It is even better if you can read the code without a comment. Good code > doesn't need comments.
Yes. But from my point of view, the current code needs a comment to explain why do we take ->pi_lock, this is hard to understand at least to me.
It is even better if we don't take ->pi_lock for ->wait_list manipulation.
Imho.
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |