Messages in this thread | | | Date | Mon, 14 Aug 2006 10:14:45 -0400 | Subject | Re: [PATCH] Added MIPS RM9K watchdog driver | From | (Joseph Fannin) |
| |
On Sat, Aug 12, 2006 at 01:49:23AM +0200, Thomas Koeller wrote: > On Friday 11 August 2006 22:56, Dave Jones wrote: > > On Thu, Aug 10, 2006 at 11:19:13PM +0200, thomas@koeller.dyndns.org wrote: > > > + > > > +#include <linux/config.h> > > > > not needed. > > It is, otherwise I do not get CONFIG_WATCHDOG_NOWAYOUT.
It shouldn't be necessary, so it's probably a bug. I could not begin to tell you where.
I've CC'd the Kbuild maintainer -- apologies if I'm way off base here.
Still, if this #include is to stay, you'd probably better comment it, or it's likely someone will rip it out in a cleanup:
http://www.gossamer-threads.com/lists/linux/kernel/663918
> > > > > > +static int locked = 0; > > > > unneeded initialisation. > > Not strictly needed, that's true, but does not do any harm either > and expresses the intention clearly.
My meager understanding is that it makes the kernel image bigger.
> > > > > +static int nowayout = > > > +#if defined(CONFIG_WATCHDOG_NOWAYOUT) > > > + 1; > > > +#else > > > + 0; > > > +#endif > > > > static int nowayout = CONFIG_WATCHDOG_NOWAYOUT; > > > > should work. > > Does not work. If the option is not selected, CONFIG_WATCHDOG_NOWAYOUT > is undefined, not zero.
Possibly related?
-- Joseph Fannin jhf@columbus.rr.com || jfannin@gmail.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |