lkml.org 
[lkml]   [2006]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subjectprepare to kill wall_jiffies
From
With 2.6.18-rc4-mm1, now jiffies and wall_jiffies are always synced.
So we can kill wall_jiffies completely.

Looking how wall_jiffies is used now, I found a potential problem on
arch/ppc and arch/xtensa:

if (ntp_synced() &&
xtime.tv_sec - last_rtc_update >= 659 &&
abs((xtime.tv_nsec/1000)-(1000000-1000000/HZ))<5000000/HZ &&
jiffies - wall_jiffies == 1) {

if (platform_set_rtc_time(xtime.tv_sec+1) == 0)
last_rtc_update = xtime.tv_sec+1;

The condition "jiffies - wall_jiffies == 1" might be correct for
kernel 2.4, but useless now. So this RTC updating never work.

Though the "11 min RTC update" might be disappeared from the kernel in
the future (any real plan?), it is better to fix this condition
anyway, isn't it?

---
Atsushi Nemoto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-13 18:21    [W:0.120 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site