Messages in this thread Patch in this message | | | Date | Mon, 14 Aug 2006 00:11:10 +0400 | From | Oleg Nesterov <> | Subject | [PATCH] elf_core_dump: don't take tasklist_lock |
| |
do_each_thread() is rcu-safe, and all tasks which use this ->mm must sleep in wait_for_completion(&mm->core_done) at this point, so we can use RCU locks.
Also, remove unneeded INIT_LIST_HEAD(new) before list_add(new, head).
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 2.6.18-rc3/fs/binfmt_elf.c~elf 2006-07-16 01:53:08.000000000 +0400 +++ 2.6.18-rc3/fs/binfmt_elf.c 2006-08-13 23:42:24.000000000 +0400 @@ -1480,20 +1480,19 @@ static int elf_core_dump(long signr, str if (signr) { struct elf_thread_status *tmp; - read_lock(&tasklist_lock); + rcu_read_lock(); do_each_thread(g,p) if (current->mm == p->mm && current != p) { tmp = kzalloc(sizeof(*tmp), GFP_ATOMIC); if (!tmp) { - read_unlock(&tasklist_lock); + rcu_read_unlock(); goto cleanup; } - INIT_LIST_HEAD(&tmp->list); tmp->thread = p; list_add(&tmp->list, &thread_list); } while_each_thread(g,p); - read_unlock(&tasklist_lock); + rcu_read_unlock(); list_for_each(t, &thread_list) { struct elf_thread_status *tmp; int sz; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |