Messages in this thread Patch in this message | | | Date | Sun, 13 Aug 2006 18:16:54 +0800 | From | Akinobu Mita <> | Subject | [PATCH] check return value of kmalloc() in setup_cpu_cache() |
| |
This patch makes crash happen when allocation of cpucache data fails in setup_cpu_cache(). It is a bit better than getting kernel NULL pointer dereference later.
CC: Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by: Akinobu Mita <mita@miraclelinux.com>
mm/slab.c | 1 + 1 file changed, 1 insertion(+)
Index: work-failmalloc/mm/slab.c =================================================================== --- work-failmalloc.orig/mm/slab.c +++ work-failmalloc/mm/slab.c @@ -1932,6 +1932,7 @@ static void setup_cpu_cache(struct kmem_ } else { cachep->array[smp_processor_id()] = kmalloc(sizeof(struct arraycache_init), GFP_KERNEL); + BUG_ON(!cachep->array[smp_processor_id()]); if (g_cpucache_up == PARTIAL_AC) { set_up_list3s(cachep, SIZE_L3); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |