lkml.org 
[lkml]   [2006]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/6] ehea: header files
    From
    Date
    On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote:
    > Hi,
    >
    > > drivers/net/ehea/ehea.h | 452
    >
    > > +#define EHEA_DRIVER_NAME "IBM eHEA"
    >
    > You are using this for ethtool get_drvinfo. Im not sure if it should
    > match the module name, and I worry about having a space in the name. Any
    > ideas on what we should be doing here?

    I believe it must match the module name. It also might be nice to call
    it "DRV_NAME" like most other network drivers do.

    cheers

    --
    Michael Ellerman
    IBM OzLabs

    wwweb: http://michael.ellerman.id.au
    phone: +61 2 6212 1183 (tie line 70 21183)

    We do not inherit the earth from our ancestors,
    we borrow it from our children. - S.M.A.R.T Person
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2006-08-14 05:23    [W:0.022 / U:31.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site