lkml.org 
[lkml]   [2006]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: 2.6.18-rc3-mm2 - BUG in rt6_lookup() from ipv6_del_addr()
    From
    From: Valdis.Kletnieks@vt.edu
    Date: Thu, 10 Aug 2006 22:15:26 -0400

    > On Sun, 06 Aug 2006 03:08:09 PDT, Andrew Morton said:
    > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc3/2.6.18-rc3-mm2/
    >
    > After applying the patch that Patrick McHardy pointed me at, it lived
    > longer. However, I'm now seeing problems at system shutdown (or anytime
    > you try to 'ifdown ethX' where ethX has an IPv6 address attached to it):

    This is cured by yet another fix already in the net-2.6.19
    tree:

    From 7a3a5e6b0e6847749c756cbe4bf554eda063a577 Mon Sep 17 00:00:00 2001
    From: Ville Nuorvala <vnuorval@tcs.hut.fi>
    Date: Tue, 8 Aug 2006 16:44:17 -0700
    Subject: [PATCH] [IPV6]: Make sure fib6_rule_lookup doesn't return NULL

    The callers of fib6_rule_lookup don't expect it to return NULL,
    therefore it must return ip6_null_entry whenever fib_rule_lookup fails.

    Signed-off-by: Ville Nuorvala <vnuorval@tcs.hut.fi>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    ---
    net/ipv6/fib6_rules.c | 6 +++++-
    1 files changed, 5 insertions(+), 1 deletions(-)

    diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
    index bf9bba8..22a2fdb 100644
    --- a/net/ipv6/fib6_rules.c
    +++ b/net/ipv6/fib6_rules.c
    @@ -63,7 +63,11 @@ struct dst_entry *fib6_rule_lookup(struc
    if (arg.rule)
    fib_rule_put(arg.rule);

    - return (struct dst_entry *) arg.result;
    + if (arg.result)
    + return (struct dst_entry *) arg.result;
    +
    + dst_hold(&ip6_null_entry.u.dst);
    + return &ip6_null_entry.u.dst;
    }

    static int fib6_rule_action(struct fib_rule *rule, struct flowi *flp,
    --
    1.4.2.rc2.g3e042

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-11 06:23    [W:0.026 / U:2.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site