lkml.org 
[lkml]   [2006]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/6] ehea: header files

    Hi,

    > drivers/net/ehea/ehea.h | 452

    > +#define EHEA_DRIVER_NAME "IBM eHEA"

    You are using this for ethtool get_drvinfo. Im not sure if it should
    match the module name, and I worry about having a space in the name. Any
    ideas on what we should be doing here?

    > +#define NET_IP_ALIGN 0

    Shouldnt override this in your driver.

    > +#define EDEB_P_GENERIC(level, idstring, format, args...) \
    > +#define EDEB_P_GENERIC(level,idstring,format,args...) \
    > +#define EDEB(level, format, args...) \
    > +#define EDEB_ERR(level, format, args...) \
    > +#define EDEB_EN(level, format, args...) \
    > +#define EDEB_EX(level, format, args...) \
    > +#define EDEB_DMP(level, adr, len, format, args...) \

    There are a lot of debug statements in the driver. When doing a review
    I stripped them all out to make it easier to read. As suggested by
    others, using the standard debug macros (where still required) would be
    a good idea.

    Anton
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-11 23:47    [W:0.019 / U:1.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site