Messages in this thread | | | Date | Thu, 10 Aug 2006 10:34:15 +0200 | From | "Jan Beulich" <> | Subject | Re: [patch] i386: annotate the rest of entry.s::nmi |
| |
>>> Andi Kleen <ak@suse.de> 10.08.06 10:26 >>> >On Thursday 10 August 2006 10:23, Jan Beulich wrote: >> >>> Chuck Ebbert <76306.1226@compuserve.com> 10.08.06 06:59 >>> >> >Part of the NMI handler is missing annotations. Just moving >> >the RING0_INT_FRAME macro fixes it. And additional comments >> >should warn anyone changing this to recheck the annotations. >> >> I have to admit that I can't see the value of this movement; > >Should I drop it again?
I would suggest so, but would also want to wait for Chuck to perhaps provide some background on why he felt these annotations were useful.
Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |