Messages in this thread | | | Date | Fri, 11 Aug 2006 00:52:16 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 00/12] ThinkPad embedded controller and hdaps drivers (version 2) |
| |
Hi!
> > Patches look great and I am glad someone has apparently better access > > to hardware specs than I did. > > This situation is still a concern. From where did this additional register > information come?
Well, I do not see much additional register information:
1/12: Seems to be based on http://documentation.renesas.com/eng/products/mpumcu/rej09b0300_2140bhm.pdf (and says so in the opening comment)
2/12: Seems to only rename already-known data.. plus adds some knowledge of embedded controller, probably from pdf above.
3/12: seems to refactor existing code.
4/12: queued events are embedded controller's feature, I guess, so this should be easy to guess.
5/12: pure linux side code. 6/12: pure linux side code. 7/12: pure linux side code.
8/12: this adds names for things we knew already. Again, this looks like easy enough to guess. "hdaps_check_ec - checks something about the EC" ... does not look like it came from leaked info.
(Is this what people have biggest problem with? 1-7 are still very nice cleanups...)
9/12: pure linux side code. 10/12: pure linux side code. 11/12: pure linux side code.
12/12: improved whitelist. Trivial after discovery that some bit tells you if accelerometer is there. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |