Messages in this thread | | | Date | Thu, 10 Aug 2006 10:49:54 -0700 | From | "Randy.Dunlap" <> | Subject | Re: [Ext2-devel] [PATCH 1/9] extents for ext4 |
| |
On Thu, 10 Aug 2006 13:29:56 +0400 Alex Tomas wrote:
> >>>>> Andrew Morton (AM) writes: > > >> From a quick scan: > > AM> - The code is very poorly commented. I'd want to spend a lot of time > AM> reviewing this implementation, but not in its present state. > > what sort of comments are you expecting?
Helpful ones. Not obvious stuff. Intents. Tricks used (if they are the right thing to do).
How, what, why. But not nitty-gritty details of how. "Why" is often more important.
> AM> - The existing comments could benefit from some rework by a native English > AM> speaker. > > could someone assist here, please?
Yes. How would you like it? Just comments via email or (quilt) patches? Which files/patches?
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |