Messages in this thread | | | Date | Thu, 10 Aug 2006 07:10:29 -0700 | From | Keshavamurthy Anil S <> | Subject | Re: [PATCH 1/3] Kprobes: Make kprobe modules more portable |
| |
On Wed, Aug 09, 2006 at 05:18:54PM +0100, Christoph Hellwig wrote: > + */ > + if (p->symbol_name) { > + if (p->addr) > + return -EINVAL; > + p->addr = kprobe_lookup_name(p->symbol_name); > + } > + > + if (!p->addr) > + return -EINVAL; > + p->addr += p->offset; This should be p->addr = (kprobe_opcode_t *)(((char *)p->addr) + p->offset), since p->addr is of type pointer to kprobe_opcode_t and the size of kprobe_opcode_t is different for different architecture. At least for ia64 this p->addr type is not a pointer to char.
-Anil Keshavamurthy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |