lkml.org 
[lkml]   [2006]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] Kprobes: Make kprobe modules more portable
    On Wed, Aug 09, 2006 at 05:18:54PM +0100, Christoph Hellwig wrote:
    > + */
    > + if (p->symbol_name) {
    > + if (p->addr)
    > + return -EINVAL;
    > + p->addr = kprobe_lookup_name(p->symbol_name);
    > + }
    > +
    > + if (!p->addr)
    > + return -EINVAL;
    > + p->addr += p->offset;
    This should be p->addr = (kprobe_opcode_t *)(((char *)p->addr) + p->offset), since p->addr is of type
    pointer to kprobe_opcode_t and the size of kprobe_opcode_t is different for different
    architecture. At least for ia64 this p->addr type is not a pointer to char.

    -Anil Keshavamurthy
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-10 16:25    [W:6.431 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site