Messages in this thread | | | Subject | Re: use persistent allocation for cursor blinking. | From | Alan Cox <> | Date | Tue, 01 Aug 2006 23:20:13 +0100 |
| |
Ar Maw, 2006-08-01 am 12:15 -0700, ysgrifennodd Roland Dreier: > > Every time the console cursor blinks, we do a kmalloc/kfree pair. > > This patch turns that into a single allocation. > > A naiive question from someone who knows nothing about this subsystem: > is there any possibility of concurrent calls into this function, for > example if there are multiple cursors on a multiheaded system?
We don't do console multihead so its basically OK. Moving all the console globals into a struct so we can have multiple instances would be a good thing [tm] and it would make sense for the variable to end up in said structure if it was done.
Definitely a janitor job there.
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |