Messages in this thread | | | Date | Sun, 9 Jul 2006 09:45:44 +0200 | From | Ingo Molnar <> | Subject | Re: [LOCKDEP] 2.6.18-rc1: inconsistent {hardirq-on-W} -> {in-hardirq-W} usage |
| |
* Andrew Morton <akpm@osdl.org> wrote:
> yup, thanks, bug. > > --- a/arch/i386/kernel/time.c~get_cmos_time-locking-fix > +++ a/arch/i386/kernel/time.c > @@ -206,15 +206,16 @@ irqreturn_t timer_interrupt(int irq, voi > unsigned long get_cmos_time(void) > { > unsigned long retval; > + unsigned long flags; > > - spin_lock(&rtc_lock); > + spin_lock_irqsave(&rtc_lock, flags);
Acked-by: Ingo Molnar <mingo@elte.hu>
this bug has been in the upstream kernel for a couple of years: it was apparently introduced as part of HPET support, via the late_time_init() hook/hack in init/main.c. The lockup window is open once, during bootup.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |