Messages in this thread | | | Subject | Re: [PATCH] Integrate asus_acpi LED's with new LED subsystem | From | Richard Purdie <> | Date | Fri, 07 Jul 2006 09:46:48 +0100 |
| |
On Thu, 2006-07-06 at 21:20 -0400, Thomas Tuttle wrote:
> +/* These functions are called by the LED subsystem to update the desired > + * state of the LED's. */ > +static void led_set_mled(struct led_classdev *led_cdev, > + enum led_brightness value); > +static void led_set_wled(struct led_classdev *led_cdev, > + enum led_brightness value); > +static void led_set_tled(struct led_classdev *led_cdev, > + enum led_brightness value);
I don't think you need these anymore.
> +#else > + > +static inline int led_initialize(struct device *parent) > +{ > +} > +
This turns the code into a game of Russian roulette when CONFIG_ACPI_ASUS_NEW_LED isn't set (think return values). I'm sure Andrew was just testing with that ;-)
If you fix these issues, you can add an Acked-by: Richard Purdie <rpurdie@rpsys.net>
Richard
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |