Messages in this thread | | | Date | Fri, 07 Jul 2006 08:32:10 +0200 | From | Henne <> | Subject | Re: [KJ] [PATCH] fix legacy megaraid-driver to compile without CONFIG_PROC_FS |
| |
>> The header I mean is /drivers/scsi/megaraid.h and is only used by megaraid.c. >> And there are the prototypes, in dependency of CONFIG_PROC_FS, for all these other proc-related functions. >> Thats why I decided to make the change there and not in megaraid.c . > > Prototypes for static functions don't belong into header files. > > That this has been done in megaraid.h in the past is something that > should be cleaned up, not a good example. > > cu > Adrian Allright, thats that kind of answer I wanted to hear. :)
Thanks and Greets, Henne
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |