[lkml]   [2006]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: splice/tee bugs?
    On Fri, Jul 07 2006, Paulo Marques wrote:
    > Jens Axboe wrote:
    > >On Fri, Jul 07 2006, Arjan van de Ven wrote:
    > >>>I cannot see where this could be happening, Ingo is this valid?
    > >>maybe the test found a way to exit the kernel previously while holding
    > >>the lock ?
    > >
    > >I don't see how that could happen. The function in question is
    > >fs/splice.c:link_pipe(). There are no returns in that function, it
    > >always just breaks out and unlocks the two mutexes again.
    > AFAICS, in the case that you don't release any lock before entering
    > pipe_wait (because of the lock ordering), pipe_wait just releases one of
    > the locks and then schedules with the other lock still held.

    That should not violate the lock ordering, though. I'm testing an easier
    fix now, basically always grabbing the ipipe mutex first and never
    blocking on the input pipe. Makes sense too, we will attempt to dupe the
    contents of that pipe from when sys_tee() was invoked. We cannot
    reliably have the pipe changing too much in progress anyway.

    Jens Axboe

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-07-07 16:07    [W:0.021 / U:5.756 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site